7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory

Alan Bateman Alan.Bateman at oracle.com
Mon May 14 08:55:46 PDT 2012


On 14/05/2012 16:32, Mike Duigou wrote:
> Looks good. It's kind of amazing that the server compiler can figure out that unsafe.getByte() is side effect free.
>
> The comment on unsused could be javadoc.
>
> You could initialize x to unused and eliminate the conditional before assignment of unused from x
>
> Mike
>
Thanks Mike. The comment on the private fields in this code use // so I 
just kept it consistent.

I didn't get comment about x = unused.  The test if unused != 0 was just 
to avoid storing to that field as it's a static. Performance wise of 
course it doesn't matter what we do as touching each page will typically 
result in lots of faulting and I/O.

-Alan


More information about the nio-dev mailing list