request for review: 6720349: (ch) Channels tests depending on hosts inside Sun

Rob McKenna rob.mckenna at oracle.com
Fri Nov 23 20:08:20 PST 2012


Almost, but not quite. TestServers.java thinks it was moved from 
TestUtil.java when I do a straight hg export/import. Not completely sure 
why. (see the webrev)

A test/java/nio/channels/TestServers.java
? test/java/nio/channels/TestServers.java.rej

The .rej file:
/*
- * Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it

Hence the request for this review really. The only change I've made was 
to the copyright line.

     -Rob


On 16/11/12 09:08, Chris Hegarty wrote:
> Targeting 7u-dev, if the same jdk8 patch ( hg export/import) , then 
> I'm fine with change.
>
> -Chris.
>
> On 15/11/2012 18:54, Rob McKenna wrote:
>> Hi folks,
>>
>> Looking for a review for:
>>
>> 6720349: (ch) Channels tests depending on hosts inside Sun
>>
>> http://cr.openjdk.java.net/~robm/6720349/webrev.01/<http://cr.openjdk.java.net/%7Erobm/7199219/webrev.01/> 
>>
>>
>> A straight backport from 8, and a very helpful fix.
>>
>> -Rob



More information about the nio-dev mailing list