request for review: 7184932: Remove the temporary Selector usage in the NIO socket adapters

[Alan Bateman]

On 04/10/2012 02:45, Rob McKenna wrote:
> Cheers Alan,
>
> Latest changes are at:
>
> http://cr.openjdk.java.net/~robm/7184932/webrev.03/ 
> <http://cr.openjdk.java.net/%7Erobm/7184932/webrev.03/>
>
>     -Rob
There's no changes to the implementation since the last round (end 
September), right?  My recollection is that the remaining discussion 
point was the test case and I see you've completely revamped it in the 
latest webrev.

I think the test looks good. You could have used a STPE and schedule the 
close or interrupt with a delay rather than having the task sleep but 
what you have is okay.

A really minor point but I'd rename dgListener and dgc to dc to be 
consistent with the other tests. Also I think that listener, dc, and 
port can be final.

Otherwise thumbs up from me and great to have this clean-up in jdk8 as 
it will reduce the resource usage for cases where applications have lots 
of socket adapters doing timed operations.

-Alan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121004/f183d2ba/attachment.html