request for review: 7184932: Remove the temporary Selector usage in the NIO socket adapters

[Alan Bateman]

On 04/10/2012 17:14, Rob McKenna wrote:
> Ah yes, sorry. I sent this out late last night after fighting with 
> some unrelated test issues. I forgot I hadn't sent the updated test to 
> the list before. So for posterity:
>
> - There were no changes to the implementation. It was all testcase.
> - The original test was loosely modelled on 
> java/nio/channels/AsynCloseAndInterrupt.java until you pointed me 
> towards this more elegant solution.
> - It was updated to also test the affected ServerSocket & 
> DatagramSocket methods.
>
> I've updated the webrev with your suggestions (incl STPE, which is 
> nicer, I guess I'm just used to writing tests that need to be 1.4.2 
> compatible) and posted it here:
>
> http://cr.openjdk.java.net/~robm/7184932/webrev.04/
>
>     -Rob
>
Thanks Rob, the changes to use STPE make this much nicer.

I hate being fussy but in the latest version you've renamed 
DatagramChannel to "peer", which I don't think is right because there 
isn't any address association or peer that you are exchanging datagrams 
with. If you rename to "dc" to be consistent with the other tests or 
anything else, then I think we are done (BTW: no need to send out 
another webrev for such a change, we've done enough rounds on this).

-Alan.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121004/d96b1711/attachment-0001.html