Review request for test bug 8015765: java/nio/channels/ServerSocketChannel/AdaptServerSocket.java

Chris Hegarty chris.hegarty at oracle.com
Tue Aug 13 06:48:59 PDT 2013


This test looks a little bizarre, and certainly racy. What you have done 
should make the test more reliable.

I noticed that the server socket channel is only closed if a socket is 
accepted. I think it should be closed always, regardless of whether a 
socket is accepted or not. Though this is not directly related to your 
changes.

-Chris

On 08/13/2013 12:24 PM, Eric Wang wrote:
> Hi,
>
> Please help to review the fix below for the bug
> https://jbs.oracle.com/bugs/browse/JDK-8015765.
> http://cr.openjdk.java.net/~ewang/8015765/webrev.00/
>
> As the test is depended on thread schedule, it may fail
> intermittently.The fix is to adjust thread priority, and increase thread
> sleep duration, to make it more stable.
>
> Thanks,
> Eric


More information about the nio-dev mailing list