[PATCH] Review request for bug 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8)

[Alan Bateman]

On 22/08/2013 11:18, Eric Wang wrote:
> Hi,
>
> Please review the fix for bug 
> https://bugs.openjdk.java.net/browse/JDK-8023139, the test fails due 
> to interference of McAfee.
> As McAfee cannot be configured due to company policy, the fix is to 
> workaround the interference by checking the modify event of the 
> expected file can always be found in the event queue.
>
> http://cr.openjdk.java.net/~ewang/8023139/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eewang/8023139/webrev.00/>
Thanks for looking into this one, these interference issues are a royal 
pain.

Your approaching to filtering is okay but it drops the check that the 
event is a modify event. I've taken your patch and massaged it a bit to 
this:

http://cr.openjdk.java.net/~alanb/8023139/webrev/

If you are okay with this and I can sponsor the patch and get it pushed 
for you.

-Alan.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20130823/35c033ec/attachment.html