RFR for JDK-8022879 TEST_BUG: sun/nio/cs/MalformedSurrogates.java fails intermittently

Mike Duigou mike.duigou at oracle.com
Thu Dec 19 11:22:53 PST 2013


On Dec 19 2013, at 09:02 , Martin Buchholz <martinrb at google.com> wrote:

> I haven't really been a "sponsor" - that's traditionally been done only by Sun/Oracle folks.  I'd be more comfortable having a nio owner sponsor it.
> But I looked at your change with "sponsor hat" on.
> The patch file should be in "hg export" format so that a sponsor can hg import it.  If the webrev script can't generate such patches, it should be fixed.

webrev will generate an export changeset if the changeset is committed. Many people (inexplicably) don't use MQ or shelve and want patches generated from the active diffs in their repos. When you see a patch associated with a webrev it's because either it's uncommitted work or crosses repos.

Mike



More information about the nio-dev mailing list