A race problem about select in a small time window
Chris Hegarty
chris.hegarty at oracle.com
Tue Mar 12 08:00:45 PDT 2013
On 03/10/2013 09:16 PM, Alan Bateman wrote:
> ....
> http://cr.openjdk.java.net/~alanb/8009751/webrev/
>
> The changes essentially mean that the Selector will now maintain an
> accurate view of the registrations so that the bulk update (at select
> time) does not need to be concerned with the channel state. For
> interestOps then it keeps it very simple as it just "queues" the update.
> The release is also simple as it do longer need to iterate over the
> pending updates.
Similar to DevPollArrayWrapper, right?
> So far I've only done limited testing but all tests that I've tried so
> far pass. I don't know the background to your test case/patch but it
> would be great if you could test the patch with the application or test
> that you originally ran into this issue with.
>
> I think for now we can use 8009751 for this issue. As part this patch
> I've also changed a lot of other code (impact the other Selectors) but
> I'll this back for now so as now (the clean-up can be done in a later bug).
Thanks for holding back on the cleanup, and separating it into another
bug. This area is very tricky to review.
Anyway, the changes look good to me.
-Chris
>
> -Alan.
More information about the nio-dev
mailing list