[nio dev] [8] Review request for 8028049 : Tidy warnings cleanup for packages java.nio/java.io
Yuri Nesterenko
yuri.nesterenko at oracle.com
Mon Nov 18 04:32:02 PST 2013
On 11/18/2013 02:29 PM, Alan Bateman wrote:
> On 18/11/2013 09:48, Yuri Nesterenko wrote:
>> The fix looks OK to me: may I review it being jdk8 Reviewer?
>> I hope I can push it for Sergey to tl repository
>> if there is no objections.
>>
> Joe and I did review it. There is one outstanding comment in Joe's
> original mail suggesting that the link in the package description be
> changed to a linkplain (the </code> ... </code> usage in the link used
> to be common to get things to look right). I don't think the webrev was
> updated so if you are sponsoring this then can you check on that point
> to make sure that it looks okay in the generated javadoc.
>
> -Alan.
Hi Alan,
we duly compared: it looked very much the same in this exact place.
Somewhere a removed "<p>" without "<br>" resulted in someway smaller
line space -- but it was agreed that's not a problem.
So I'm putting you and Joe as the reviewers and pushing the fix.
Thanks,
-yan
More information about the nio-dev
mailing list