Review request for bug 8015762: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java fails intermittently

Alan Bateman Alan.Bateman at oracle.com
Wed Sep 11 02:23:50 PDT 2013


On 11/09/2013 09:58, Eric Wang wrote:
> Hi Alan,
>
> Sorry for late. I have re-fixed this failure, Can you please help to 
> review?
> I executed the tests on the host jsn-vm49.us for thousands times and 
> found the test failed as setting SO_TIMEOUT for 5 seconds is not 
> enough to wait response sent by a new created thread of 
> UdpEchoRequest. It may caused by thread schedule as there's maybe more 
> than 3 threads executing at sametime or full GC as lots of 
> UdpEchoRequest created in runtime.
>
> The fix is to change the SO_TIMEOUT from 5 seconds to 10 and not 
> create a new thread of UdpEchoRequest to send response. I have run the 
> fix for 20000 times, it works fine.
> http://cr.openjdk.java.net/~ewang/8015762/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eewang/8015762/webrev.01/>
>
Thanks for confirming that the 5 second timeout is insufficient, that 
part is clear now.

The webrev also updates TestServers so that start runs the task 
directly. Is this meant to be part of this change?

-Alan.



More information about the nio-dev mailing list