Regression in EPollArrayWrapper causes NPE when fd > 64 * 1024

[Alan Bateman]

On 17/09/2013 12:54, Norman Maurer wrote:
> Hi Alan,
>
> just a tiny thing but why not check if force is true before try to 
> access the Map (like in my proposed patches)? Not sure it gives much 
> gain in terms of performance but it can't harm at all…
It's so that it is consistent with the eventsLow check. Performance-wise 
I don't see any difference as updated aren't forced when changing the 
registration. If you want to check then it's okay but I'd prefer that 
the order be consistent for both eventsLow and eventsHigh.

>
> About the test-case, I think it's important to have a test cover the 
> usage of the eventsHigh Map. Otherwise it's just "too easy" to break 
> things and it may be take some time to get noticed as only "a few" 
> users are affected. I think you could even "adjust" the 
> MAX_UPDATE_ARRAY_SIZE with reflection if you not want to expose it.
Using reflection to change is a good idea (better than using a system 
property as I was initially thinking). Do you want to contribute a test? 
The simplest would be to re-run one of the existing stress tests with 
this set to a small value.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20130917/29c87b49/attachment.html