Regression in EPollArrayWrapper causes NPE when fd > 64 * 1024

[Norman Maurer]

Sorry forgot to say that I'm ok with your proposed fix now. So feel free to push and add me as contributor. Hopefully I will have a test for you tomorrow.

Bye,
Norman
 
---
Norman Maurer
nmaurer at redhat.com

JBoss, by Red Hat



Am 17.09.2013 um 14:12 schrieb Norman Maurer <nmaurer at redhat.com>:

> Am 17.09.2013 um 14:08 schrieb Alan Bateman <Alan.Bateman at oracle.com>:
> 
>> On 17/09/2013 12:54, Norman Maurer wrote:
>>> 
>>> Hi Alan,
>>> 
>>> just a tiny thing but why not check if force is true before try to access the Map (like in my proposed patches)? Not sure it gives much gain in terms of performance but it can't harm at all… 
>> It's so that it is consistent with the eventsLow check. Performance-wise I don't see any difference as updated aren't forced when changing the registration. If you want to check then it's okay but I'd prefer that the order be consistent for both eventsLow and eventsHigh.
> 
> Ok I think it should be ok then. Thanks for clarify.
> 
>> 
>>> 
>>> About the test-case, I think it's important to have a test cover the usage of the eventsHigh Map. Otherwise it's just "too easy" to break things and it may be take some time to get noticed as only "a few" users are affected. I think you could even "adjust" the MAX_UPDATE_ARRAY_SIZE with reflection if you not want to expose it.  
>> Using reflection to change is a good idea (better than using a system property as I was initially thinking). Do you want to contribute a test? The simplest would be to re-run one of the existing stress tests with this set to a small value.
> 
> Sure why not, this would be good thing to complete the fix and proof it. Can you point me to one of the tests you are refer to ?
> 
>> 
>> -Alan.
> 
> 
> ---
> Norman Maurer
> nmaurer at redhat.com
> 
> JBoss, by Red Hat
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20130917/8730f9ac/attachment.html