RFR JDK-8034057: Files.getFileStore and Files.isWritable do not work with SUBST'ed drives (win)

Alan Bateman Alan.Bateman at oracle.com
Tue Apr 29 11:01:47 UTC 2014


On 29/04/2014 11:01, Pavel Rappo wrote:
> Hi everyone,
>
> could you please review my change for JDK-8034057: http://cr.openjdk.java.net/~alanb/8034057/webrev/
>
> It turns out some of win32 functions don't work well with SUBSTed drives (namely GetVolumePathName). As a result it fails to create WindowsFileStore. This is a simple fallback type solution. It first tries to create WindowsFileStore the old way and if it fails with specific error, tries different approach.
>
The approach looks okay, I can sponsor this for you.

One small thing, are you sure you need to specify "file" in the 
exception message? FileSystemException will already include the file 
path in the exception message.

-Alan


More information about the nio-dev mailing list