RFR JDK-8066678: java.nio.channels.Channels cleanup

Alan Bateman Alan.Bateman at oracle.com
Thu Dec 4 14:01:54 UTC 2014


On 04/12/2014 12:23, Pavel Rappo wrote:
> Hi everyone,
>
> Could you please review my change for JDK-8066678?
>
> http://cr.openjdk.java.net/~prappo/8066678/webrev.00/
>
> It's a minor cleanup. Main things fixed:
>
> 	* Substituted Channels.checkNotNull for Objects.Objects.requireNonNull
>            (non-essential difference is the NPE message)
> 	* Javadoc fixes
>
The change to use Objects.requireNonNull looks okay. Also removing the 
"open" flag from WritableByteChannelImpl is okay.

I don't agree with the javadoc changes, it makes this class inconsistent 
with the other classes in this area. The changes to use {@code ... } are 
good.

-Alan


More information about the nio-dev mailing list