8025619: (fc) FileInputStream.getChannel on closed stream returns FileChannel that doesn't know that stream is closed

[Alan Bateman]

On 05/12/2014 22:06, Brian Burkhalter wrote:
> :
>
> Here’s an updated patch which extends Alan’s suggested patch:
>
> http://cr.openjdk.java.net/~bpb/8025619/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8025619/webrev.01/>
>

I think you need to make channel volatile, this also means you can 
change getChannel() to use the double-checked locking idiom.

You can make closed final.

The changes to FileKey aren't strictly required but shouldn't be an issue.

I think the test should assert that the channel is closed. There isn't 
anything special with tryLock but if you want to attempt a few 
operations to checking that ClosedChannelException is thrown then that 
would be good.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20141206/2876628e/attachment.html>