RFR 9: 8030090: (fs) Add default methods to Path for derived methods

[Brian Burkhalter]

On Dec 17, 2014, at 12:51 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> This mostly looks good to me although I assumed that sun.nio.fs.AbstractPath would be removed. Is there any reason to keep it?

I expect I incorrectly interpreted this comment from the issue description:

"The only one that needs adjustment is toFile() as it should only return a File if the Path is associated with the default file system. “
            
> In the toFile() method then it should use == rather than equals as FileSystems.getDefault() returns the singleton that is the default provider.

I was wondering about that.

> The UOE line is a bit long, might be best to try to get the line lengths consistent if you can.
> 
> In resolveSibling then a comma after "{@code other == null}" would make it read a bit better.
> 
> In the iterator method then I wonder if the @implSpec should be reduced down to a statement to specify that it just returns an Iterator to iterate over elements 0 to getNameCount()-1.

The current @implSpec was arrived at after a few iterations on the verbiage. I can pare it down to this however which seems reasonable.

> One thing for the default implementation is that we don't need remove.

Good point: I forgot to check that it’s a default now in Iterator.

> Formatting nit at L779-L780, you could move the @throws to the previous line or put the { on the next line.
> 
> A general comment is that you could use "this path" rather than "this {@code Path}" in each of the @implNotes if that looks better.

I’ll make some changes and re-post for review.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20141217/7f78f4d1/attachment.html>