RFR: JDK-8036134 - Check src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c for JNI pending exceptions
Mark Sheppard
mark.sheppard at oracle.com
Fri Mar 14 13:38:58 UTC 2014
Hi Alan,
OK .. I thought I added a JNU_ThrowOutOfMemoryError for the malloc,
as I've done with others
the other complaint in on the last throwWindowsException, could have a
pending exception from
previous throwWindowsException, so modified the flow, rather than add an
ExceptionCheck.
Looking at it again, I don't think the flow is as I intended, as a
returns values from Windows API calls are
0 and > 0, no < 0 case!!
Let me revisit it
regards
Mark
On 14/03/2014 13:04, Alan Bateman wrote:
> On 13/03/2014 18:59, Mark Sheppard wrote:
>> Hi
>> Please oblige and review the following changes
>> http://cr.openjdk.java.net/~msheppar/8036134/webrev/
>>
>> which address the issues raised in
>> https://bugs.openjdk.java.net/browse/JDK-8036134
>>
>> summary:
>> modification to logic flow to handle JNI pending exception
> If malloc fails then it doesn't throw JNU_ThrowOutOfMemoryError but
> otherwise I'm not sure that I see a problem. Is the bug report for the
> case that GetFinalPathNameByHandle fails when calls with the larger
> buffer?
>
> -Alan
More information about the nio-dev
mailing list