RFR: JDK-8036134 - Check src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c for JNI pending exceptions

Mark Sheppard mark.sheppard at oracle.com
Fri Mar 14 17:17:29 UTC 2014


  Chris
     thanks for the review

M.
On 14/03/2014 17:10, Chris Hegarty wrote:
> Looks ok to me Mark.
>
> -Chris.
>
> On 14 Mar 2014, at 16:55, Mark Sheppard <mark.sheppard at oracle.com> wrote:
>
>> updated changes for review at
>> http://cr.openjdk.java.net/~msheppar/8036134/webrev.01/
>>
>> regards
>> Mark
>>
>> On 14/03/2014 13:04, Alan Bateman wrote:
>>> On 13/03/2014 18:59, Mark Sheppard wrote:
>>>> Hi
>>>>    Please oblige and review the following changes
>>>> http://cr.openjdk.java.net/~msheppar/8036134/webrev/
>>>>
>>>> which address the issues raised in
>>>> https://bugs.openjdk.java.net/browse/JDK-8036134
>>>>
>>>> summary:
>>>> modification to logic flow to handle JNI pending exception
>>> If malloc fails then it doesn't throw JNU_ThrowOutOfMemoryError but otherwise I'm not sure that I see a problem. Is the bug report for the case that GetFinalPathNameByHandle fails when calls with the larger buffer?
>>>
>>> -Alan



More information about the nio-dev mailing list