RFR [8011537]: (fs) Path.register(..) clears interrupt status of thread with no InterruptedException

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue May 6 19:17:10 UTC 2014


Thank you Alan!

On 06.05.2014 19:02, Alan Bateman wrote:
> On 06/05/2014 15:52, Ivan Gerasimov wrote:
>> I tried to make the added test consistent with the rest of the code.
>> I can surely rewrite it, but should I refactor other code as well then?
> I think the the existing tests pre-date the vararg variant of 
> register, there isn't a big need to change those.
>
> For the new test then it would be good to use try-with-resources here.
>
Okay, changed it.

> It would be good to change testExceptions too but not important for 
> this change.
>
I think it can be changed with the upcoming fix for 8042470, which will 
include modifications to this test anyways.

Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8011537/1/webrev/

Sincerely yours,
Ivan



More information about the nio-dev mailing list