RFR JDK-8043495: add native FileChannelImpl.transferTo0() implementation for AIX

Volker Simonis volker.simonis at gmail.com
Tue May 27 08:49:46 UTC 2014


On Tue, May 27, 2014 at 8:49 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 27/05/2014 07:31, Jonathan Lu wrote:
>>
>> Hi Alan,
>>
>> Thank you for the comments, here's the updated webrev,
>> http://cr.openjdk.java.net/~luchsh/JDK-8043495-2/
>> <http://cr.openjdk.java.net/%7Eluchsh/JDK-8043495-2/>
>
> Thanks for the updates and for including the the ifdef __APPLE__ change.
> With the getsockopt removed then maybe socket.h is not needed now? Otherwise
> looks good to me.

'send_file()' is declared in 'sys/socket.h' on AIX, so we need it.

The change looks good to me as well. Thanks for contributing it!

Is there any test which exercises this code?

Regards,
Volker

>
> -Alan.


More information about the nio-dev mailing list