Request for review/advice from langtools team<was> Re: Covariant overrides on the Buffer Hierarchy redux

[Joel Borggrén-Franck]

Hi Paul,

Sorry for the delay.

So if I understand this correctly, we get 4 warnings (and because of -Werror a build failure) in langtools when compiling vs Jdk 9, but need the casts because we bootstrap with Jdk 8.

Looks good to me but I would prefer if you filed a bug on me for Jdk 10 for removing the SuppressWarnings and added comments pointing to the bug after the @SuppressWarnings annotations. That way I will remember to clean this up when we bootstrap with Jdk 9.

cheers
/Joel

On 27 okt 2014, at 10:12, Paul Sandoz <paul.sandoz at oracle.com> wrote:

> Hi,
> 
> Can someone from langtools kindly chime in with how to move this forward?
> 
>  https://bugs.openjdk.java.net/browse/JDK-4774077
> 
>  http://cr.openjdk.java.net/~rwarburton/buffer-overrides-3/
> 
>  http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtools.patch
> 
> 
> On Oct 17, 2014, at 11:37 AM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
> 
>> Hi,
>> 
>> [Including compiler-dev, i am not on that list so please CC me if replying to just that list]
>> 
>> 
> ...
> 
> 
>> So Richard has a patch for that too:
>> 
>>  http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtools.patch
>> 
>> This is required because in the bootstrap compilation phase a JDK without the co-variant overrides can be used. So the current solution is to suppress the warnings. Reviews from langtools gurus are very much appreciated.
>> 
> 
> ?
> 
> 
>> Ideally it would be nice to push all this under one issue, is that possible? If not i will have to create another issue and of course push to langtools before jdk.
>> 
>> A internal CCC is also underway.
>> 
> 
> This has be approved, with the comment that "@since 1.9" should be added to the doc of the new methods, which i have done in my copy of the patch.
> 
> Thanks,
> Paul.