RFR [8054029] (fc) FileChannel.size() returns 0 for block devices

Alan Bateman Alan.Bateman at oracle.com
Sat Sep 13 13:54:04 UTC 2014


On 12/09/2014 16:10, Ivan Gerasimov wrote:
>
> As you suggested, I updated the test: it's now skipped unless 
> /dev/sda1 is found and readable.
>
> Here's the new webrev:
> http://cr.openjdk.java.net/~igerasim/8054029/1/webrev/
This looks okay to me.

A minor comment is that it's more usual to use "private static final 
..." (the ordering of modifiers doesn't matter of course). I think I 
would probably using one static like this:

    private static final BLK_FILE = Paths.get("/dev/sda1");

rather than two but it's not important.

-Alan


More information about the nio-dev mailing list