RFR [8058099] (ch) Cleanup in FileChannel/FileDispatcher native implementation [win]
Alan Bateman
Alan.Bateman at oracle.com
Wed Sep 24 15:35:29 UTC 2014
On 23/09/2014 15:53, Ivan Gerasimov wrote:
>
> It's not that clear from MSDN whether UnlockFileEx() can ever report
> ERROR_IO_PENDING.
> However, it does say that it's able to work asynchronously.
>
> I think it would be safer to add the check for ERROR_IO_PENDING.
> Here's the updated webrev:
> http://cr.openjdk.java.net/~igerasim/8058099/1/webrev/
>
> Thanks! Would you please review this small addition to release0()?
The updated webrev looks okay. The only thing that caught by eye is the
ignoring of ERROR_NOT_LOCKED, I can't tell if that is bogus or not (but
ignore my comment for now, this pre-dates your changes).
-Alan
More information about the nio-dev
mailing list