[9] RFR of 8065556: (bf) Buffer.position and other methods should include detail in IAE
Brian Burkhalter
brian.burkhalter at oracle.com
Tue Apr 21 22:22:48 UTC 2015
Another iteration of this patch has been posted at
http://cr.openjdk.java.net/~bpb/8065556/webrev.04/
to be reviewed at your convenience.
Summary:
1) Exception creation methods renamed for consistency to createXYZException().
2) Methods in #1 still create and return an IAE but leave throwing it to the caller.
3) Static methods in #1 moved up below constructors for style consistency.
4) Line lengths adjusted in tests to be within conventional limits.
Thanks,
Brian
On Apr 21, 2015, at 12:36 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> To re-clarify, given the issue that Vitaly and previously Martin referred to, I think that if name consistency were desirable then something like createXXXException() (createNegativeCapacityException() or createPositionOutOfBoundsException() for example) with the throw statement remaining in the caller would be more appropriate.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150421/51d31dab/attachment.html>
More information about the nio-dev
mailing list