[9] RFR of 8065556: (bf) Buffer.position and other methods should include detail in IAE

[Brian Burkhalter]

On Apr 23, 2015, at 9:38 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> The approach looks okay to me. It would have been interesting to have done micro benchmarks to see it matches Martin's observation/bug as that was news to me.

I could do that if you like. I need to brush up on JMH anyway as I used a lot during a certain period of time but that’s a while ago now.

> In Buffer then it would be nice to reduce the method names a bit so that the declarations don't spill over two lines. I realize it's just nit picking but it's good to keep the code consistent when you can.

Understood. I’ll see what I can do. I also did not like this sort of style:

    private IllegalArgumentException createSomeException( // indent == 4
            Object someParameter, …) // indent == 8

> The test update looks okay now.

Good.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150423/1715c58c/attachment.html>