[9] RFR of 8132497: (fs) FileSystems.newFileSystem(URI, ..) doesn't handle UOE thrown by provider

Chris Hegarty chris.hegarty at oracle.com
Mon Aug 10 16:54:15 UTC 2015


This looks ok to me Brian, and consistent with newFileSystem(Path, 
ClassLoader).

The only minor comment I have is about delete(path) in the test. It 
could use the utility method from the test library, FileUtils. 
deleteFileWithRetry(Path), to avoid issues with deletion on Windows.

-Chris.

On 04/08/15 18:31, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8132497
> Webrev:	http://cr.openjdk.java.net/~bpb/8132497/webrev.00/
>
> Summary: Handle UOEs in newFileSystem(URI,...) similarly to as done in newFileSystem(Path path, ClassLoader loader).
>
> The jdk_nio regression tests passed on the usual default array of test systems.
>
> Thanks,
>
> Brian
>


More information about the nio-dev mailing list