[9] RFR of 8132497: (fs) FileSystems.newFileSystem(URI, ..) doesn't handle UOE thrown by provider

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 19 08:47:05 UTC 2015



On 10/08/2015 17:54, Chris Hegarty wrote:
> This looks ok to me Brian, and consistent with newFileSystem(Path, 
> ClassLoader).
>
> The only minor comment I have is about delete(path) in the test. It 
> could use the utility method from the test library, FileUtils. 
> deleteFileWithRetry(Path), to avoid issues with deletion on Windows.
The change to FileSystems looks okay.

I don't think the Files.delete or the jtreg library deleteFileWithRetry 
is needed in the test. If it fails then it's often best to leave 
breadcrumbs so that you look at the file that was attempted to be opened 
as a file system.

-Alan


More information about the nio-dev mailing list