[9] RFR of 8129633: (fs) Investigate removing the GNOME-based FileTypeDetector from the Linux and Solaris implementations

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 19 08:53:54 UTC 2015



On 06/08/2015 01:37, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8129633
> Patch:	http://cr.openjdk.java.net/~bpb/8129633/
>
> Summary:
>
>  From the GnomeFileTypeDetector used on Linux and Solaris remove the branch which probes using the GnomeVFS [1] abstraction layer which has been deprecated since 2008. The branch which probes using GIO [2] remains in place.
>
> With this change the jdk_nio regression tests pass on the usual Linux and Solaris variants.
>
>
This looks okay to me except that I wonder if GnomeFileTypeDetector 
should be renamed top GioFileTypeFileDetector. Also it's probably not 
too interesting to add the bug number for this issue to 
probeContentType/Basic.java.

-Alan.


More information about the nio-dev mailing list