RFR JDK-8131067: (zipfs) Zip File System Provider returns doubly-encoded Path URIsRFR

Xueming Shen xueming.shen at oracle.com
Thu Aug 27 19:36:41 UTC 2015


On 08/27/2015 12:26 PM, Alan Bateman wrote:
> On 27/08/2015 20:00, Xueming Shen wrote:
>> Hi
>>
>> Please hep review the change for  JDK-8131067.
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8131067
>> webrev: http://cr.openjdk.java.net/~sherman/8131067
>>
>> It appears URI constructor URI(scheme, ssp, fragment) quotes
>> any 'non-legal-uri-character". Need to decode the uri string from
>> path before passing into URI constructor to create a new one.
>> The "decode" is a copy/paste from the j.net.URI class with some
>> optimization.
> This looks okay. A passing comment on the test is that it could use Files.write to write "hello".
>
> -Alan

thanks! updated as suggested.


More information about the nio-dev mailing list