[9] RFR of 8139133: Changing the modification time on a unix domain socket file fails

[Alan Bateman]

On 08/12/2015 01:09, Brian Burkhalter wrote:
>
> OK so here’s one more go with the above change added:
>
> http://cr.openjdk.java.net/~bpb/8139133/webrev.04/ 
> <http://cr.openjdk.java.net/%7Ebpb/8139133/webrev.04/>
>
Good, this is where I assumed it was going when we initially discussed 
this one back in October.

One thing we could do to make this a bit clearer is for close to be a 
no-op when called with -1. I realize this requires renaming the native 
methods so not a big issue if you decide not to do it in this patch.

In setTimes then it might be a bit cleaner if you rename useFdToSetTimes 
to useFutimes.

The test is still a concern, esp. the sleep. There are also a lot of 
catching of IOException that I assume should be removed to allow the 
test to fail. Also the message "Failed to remove" isn't quite right as 
deleteIfExists returns false when the file does not exist. I think you 
can remove the try-catch around this can be removed too.

-Alan.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20151208/8893a559/attachment.html>