RFR: 8145981 (fs) LinuxWatchService can reports events against wrong directory

[Sebastian Sickelmann]

Hi Alan,

i am not fully sure, but i think your patch does not change anything.

But I think I understand what you have written in the comment. I think
there is a third possible solution to the two you mentioned.

I was not sure, if it was done intentionally (shutdown before
processing) so I have keeped the order of processing and shutdown and
only resorted the order of the reading in the special case.

Your suggested solution may be easier to read and maintain. What do you
think?

http://cr.openjdk.java.net/~sebastian/8145981/webrev.00/

The backporting to older releases should be straight forward and I will
produce changsets for those when we are ready with the review for jdk9.

On my box it takes 20-30 seconds to tickle the bug. After the fix i had
ran the test for about 10 minutes.

Do you have any good idea how to make the test more robust, so that an
regression could be detected on all your linux boxes in a short time?


--
Sebastian

On 12/28/2015 06:15 PM, Alan Bateman wrote:
>
> On 28/12/2015 14:39, Sebastian Sickelmann wrote:
>> Hi,
>>
>> I want to fix this one. Is someone working on a solution/test yet?
>>
> No problem if you take it. I did attach an initial patch to the bug
> after seeing the mails earlier today. There is a reproducer with the
> (good) bug report but it doesn't reproduce easily on any of the Linux
> machines that I tried. So one that would be great is to see whether we
> can tickle the issue quickly.
>
> -Alan
>