RFR 8144355: JDK 9 changes to ZipFileSystem to support multi-release jar files

[Alan Bateman]

On 21/12/2015 17:55, Steve Drach wrote:
> :
>
>> The changes to ZipFileSystem* looks okay although I wonder if 
>> getEntry0 should be renamed to getEntry as it's cleaner when 
>> overridden in JarFileSystem.
>
> I did not change this.  I’d like Sherman to comment on it.  I assume 
> getEntry0 was named for a reason.
It was a private method and originally wrapped with getEntry that has 
since been removed.


> :
>
> Consistent with ZipFileSystem?  As for long lines, the longest line is 
> 109 characters.  I always try to keep lines shorter than 120 
> characters.  I think it’s easier to read on a single line.  Seems like 
> a matter of style.
Best to keep it consistent with ZipFileSystem code. Also it makes it 
easier when doing side-by-side diffs.


> I don’t see what the issue is with the copyright.
>
Tests should have the GPL header, this one has the Classpath exception 
so I assume it must have been copied from a file in the src tree.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20151229/10e8bcfc/attachment-0001.html>