[9] RFR of 8072495: (fs) Path.relativize() gives incorrect result for empty path on Windows

[Brian Burkhalter]

On Feb 4, 2015, at 11:20 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 04/02/2015 22:16, Brian Burkhalter wrote:
>> Please review at your convenience:
>> 
>> Issue:	https://bugs.openjdk.java.net/browse/JDK-8072495
>> Patch:	http://cr.openjdk.java.net/~bpb/8066943/webrev.00/
>> 
>> 
> Thanks for taking this one. The changes look good. Minor point is to add 8072495 to the @bug in PathOps before you push.

Adding the bug ID to @bug slips my addled brain half the time. Thanks. Updated webrev here:

http://cr.openjdk.java.net/~bpb/8072495/webrev.01/

On Feb 5, 2015, at 4:08 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Should there be:
> 
> 518         test("")
> 519             .relativize("", "")
> 520             .relativize("a", "a")
> 521             .relativize("a\\b\\c", "a\\b\\c")
> 
> +                .relativize("C:\\a\\b\\c", "C:\\a\\b\\c”);

Added this as well.

Resubmitted a test run and will push once this passes.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150205/f162e114/attachment-0001.html>