[9] RFR of 8073445: (fs) FileSystem.getPathMatcher(...) should check syntax component without regard to case

Alan Bateman Alan.Bateman at oracle.com
Sat Feb 28 09:14:16 UTC 2015


On 27/02/2015 23:14, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8073445
> Patch:	http://cr.openjdk.java.net/~bpb/8073445/webrev.00/
The zip provider also needs to be updated, the changes to the default 
and jrt providers look good.

The PathMatcher/Basic.java test already has a test for an unknown syntax 
so that might be a better place to check that you can use both regex and 
glob in mixed case.




>
> Simply change to use the String method equalsIgnoreCase() instead of equals() on the syntax. Note that somewhat confusingly the specification in [1] states
>
>> For both the glob and regex syntaxes, the matching details, such as whether the matching is case sensitive, are implementation-dependent and therefore not specified.
>
> Does the proposed code change imply an update to this specification?
This should be okay, this is talking about the resulting PathMatcher 
rather than the case of the syntax name specified to getPathMatcher.

-Alan




More information about the nio-dev mailing list