[9] RFR of 8073078: java/nio/file/FileStore/Basic.java sensitive to NFS configuration

[Brian Burkhalter]

On Jul 1, 2015, at 11:28 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> The changes in the webrev are confusing and are hiding the security manager check.

I thought that the documentation of checkAccess() was clear enough about the permission check

"Checks that the file exists and that the Java virtual machine has permission to read the file.”

and that having one call would be better than having two: checkAccess() instead of checkRead() + access().

> Another point is that this is the Unix provider implementation so it should not be calling Paths.get. It won't work if you have you interposed on the default provider for example.

Good point.

> I suspect that all you need here:
>   access(new UnixPath(this, entry.dir()), R_OK)
> 
> but important to check that it doesn't hang when NFS server is not reachable.

Unfortunately it does hang. I am not sure how to address this problem now.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150702/7e80005c/attachment.html>