RFR 9: 8065570: (bf spec) ByteBuffer.slice() should make it clear that the initial order is BIG_ENDIAN
Brian Burkhalter
brian.burkhalter at oracle.com
Wed Jul 15 00:24:41 UTC 2015
On Jul 14, 2015, at 4:03 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 14/07/2015 02:34, Brian Burkhalter wrote:
>>
>> Webrev:
>> http://cr.openjdk.java.net/~bpb/8065570/webrev.01/
>> Specdiff:
>> http://cr.openjdk.java.net/~bpb/8065570/specdiff.01/
>>
>> The gist of the change is to bring the specification of the byte order into the method documentation in addition to having it in the package and/or class documentation.
>>
>>
> This looks right as it reinforces existing specification and implementation.
>
> Can you double-check the tests to make sure that all cases are covered?
They weren’t quite, so I modified the java/nio/Buffer/Order test such that they should be now.
Webrev: http://cr.openjdk.java.net/~bpb/8065570/webrev.02/
The additional type-specific tests are generated from a template by a script following the existing pattern.
Thanks,
Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20150714/9b3d2c14/attachment.html>
More information about the nio-dev
mailing list