[9] RFR of 8087304: (ch) java/nio/channels/DatagramChannel/EmptyBuffer.java received 4 times while expected 3
Chris Hegarty
chris.hegarty at oracle.com
Tue Jun 16 08:04:17 UTC 2015
On 15 Jun 2015, at 20:40, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> ...
>
> I think that this version of the patch
>
> http://cr.openjdk.java.net/~bpb/8087304/webrev.02/
This latest version looks good to me Brian. Nice and tidy.
Some minor comments, that if accepted do not need another webrev:
1) clientAddress does not need to be volatile, I think it can be just final.
2) A little subjective, but I would not add the bugId to the @bug tag.
This is but a testcase issue, not a product issue.
-Chris.
>
> might be more what you had in mind. I cleaned up the test a little elsewhere as well.
>
> Thanks,
>
> Brian
More information about the nio-dev
mailing list