[9] RFR of 8074821: Resolve disabled warnings for libnio

[Alan Bateman]

On 07/05/2015 02:31, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8074821
> Patch:	http://cr.openjdk.java.net/~bpb/8074821/webrev.00/
>
> Summary: Enable the indicated warnings and correct the code which provoked them.
>
> On Windows I still saw two places in Net.c provoking warning C4996 about GetVersionEx() (lines 95 and 109 in the new version) being deprecated, but I don’t think we can replace this functionality with IsWindowsVistaOrGreater() with the version of the MS compiler we are using. If I am incorrect on this point please let me know.
>
The warning related to checking rlim_max has annoyed me too and I've 
always meant to spend time on it. The background to this is platforms 
(Solaris mostly) where the limit is set to RLIM_INFINITY (-3). We had 
signed/unsigned issues in past releases that had to be worked around. 
With the patch then it is still compared an unsigned to a signed. It 
would good to check this and see if you need the cast the RHS to rlim_t.

The other changes in the patch look okay to me.

The issue of GerVersionEx being deprecated is a general issue for the 
JDK. There is a new helper API that I suspect we need to transition to 
at some point. The Microsoft folks on this mailing list might be able to 
advise on this.

-Alan