RFR JDK-8028480: (zipfs) NoSuchFileException on creating a file in ZipFileSystem with CREATE and WRITE

Xueming Shen xueming.shen at oracle.com
Wed May 27 16:01:12 UTC 2015


On 5/27/15 8:27 AM, Alan Bateman wrote:
> On 26/05/2015 20:23, Xueming Shen wrote:
>> Hi,
>>
>> Please help review the changes for JDK-8028480 and JDK-8034773
>>
>> issues:
>> https://bugs.openjdk.java.net/browse/JDK-8028480
>> https://bugs.openjdk.java.net/browse/JDK-8034773
>>
>> webrev:
>> http://cr.openjdk.java.net/~sherman/8028480_8034773/
> This looks okay but in several places it will require making a 
> defensive copy of options before they are checked.
>
> -Alan.

I'm aware of converting the options to internal flags in unix fs, but 
thought that is for the convenience...
We are not saving the options for any future/internal use, simply 
checking its value on the spot. Just wonder
really need to make the defensive copy here? The invoker changes the 
options during the invocation of this
method?

-Sherman


More information about the nio-dev mailing list