JDK 9 RFR of JDK-8068693/8153209: (ch) test java/nio/channels/AsyncCloseAndInterrupt.java failing

Roger Riggs Roger.Riggs at Oracle.com
Mon Apr 11 21:16:28 UTC 2016


Hi Hamlin,

Reinforcing Brian's suggestion, and it is worth fixing, the parameter 
should be clear that an extra sleep is required.
Perhaps 'extraSleep' == true.

+1 Reviewed.

Roger


On 4/11/2016 3:38 PM, Brian Burkhalter wrote:
> Hi Hamlin,
>
> Given your explanation it looks reasonable.
>
> A very minor point is that perhaps it would be better to call the new 
> parameter something like “canSleep” or “shouldSleep”, etc., instead of 
> “cantSleep” especially as your conditional block at lines 578-580 is:
>   578         if (!cantSleep) {
>   579             sleep(100);
>   580         }
> Possibly not worth changing however.
>
> Note that I am not your real reviewer either. ;-)
>
> Brian
>
> On Apr 11, 2016, at 3:47 AM, Hamlin Li <huaming.li at oracle.com 
> <mailto:huaming.li at oracle.com>> wrote:
>
>> Would any reviewer be available to help review the code change?
>>
>> On 2016/4/8 10:34, Hamlin Li wrote:
>>> Would any reviewer be available to help review the code change?
>>>
>>> On 2016/4/6 11:43, Hamlin Li wrote:
>>>>
>>>>
>>>> On 2016/4/6 11:35, Martin Buchholz wrote:
>>>>> I'm still not your real reviewer.
>



More information about the nio-dev mailing list