RFR: 8154455: Fix compilation issue in WindowsAsynchronousSocketChannelImpl

Claes Redestad claes.redestad at oracle.com
Mon Apr 18 14:55:03 UTC 2016


Thanks for the quick reviews, Chris and Alan,

I'll push this together with JDK-8154454 as soon as the joint JPRT run 
looks green.

/Claes

On 04/18/2016 04:44 PM, Chris Hegarty wrote:
> Looks fine.
>
> -Chris.
>
> On 18/04/16 15:34, Claes Redestad wrote:
>> Hi,
>>
>> the patch I pushed for JDK-8154436 earlier was somehow incomplete. The
>> below patch should resolve things, and is currently working its way
>> through JPRT
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154455
>>
>> /Claes
>>
>> diff -r 2b4600ed4530
>> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java 
>>
>>
>> ---
>> a/src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java 
>>
>> Mon Apr 18 16:12:35 2016 +0200
>> +++
>> b/src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java 
>>
>> Mon Apr 18 16:16:16 2016 +0200
>> @@ -649,11 +649,7 @@
>>           }
>>
>>           // initiate I/O
>> -        if (Iocp.supportsThreadAgnosticIo()) {
>> -            readTask.run();
>> -        } else {
>> -            Invoker.invokeOnThreadInThreadPool(this, readTask);
>> -        }
>> +        readTask.run();
>>           return result;
>>       }
>>
>> @@ -906,13 +902,8 @@
>>               result.setTimeoutTask(timeoutTask);
>>           }
>>
>> -        // initiate I/O (can only be done from thread in thread pool)
>>           // initiate I/O
>> -        if (Iocp.supportsThreadAgnosticIo()) {
>> -            writeTask.run();
>> -        } else {
>> -            Invoker.invokeOnThreadInThreadPool(this, writeTask);
>> -        }
>> +        writeTask.run();
>>           return result;
>>       }
>>



More information about the nio-dev mailing list