JDK 9 RFR of 8146215: (fs) java/nio/file/Files/probeContentType/Basic.java failed frequently on Solaris-sparc with Unexpected type: text/plain

Roger Riggs Roger.Riggs at Oracle.com
Mon Aug 8 19:46:33 UTC 2016


Hi Brian,

Looks fine.

I'm not sure there are any changes except an import in 
SolarisFileSystemProvider.java;
you might not need to update that.

Good to go, Roger



On 8/4/2016 1:13 PM, Brian Burkhalter wrote:
>
> On Aug 3, 2016, at 9:21 PM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> Does getFileNameMap() need the synchronization? I assume not, in 
>> which case fileNameMapLock could be removed and it could be reduced 
>> down to:
>>
>> FileNameMap map = fileNameMap;
>> if (map == null) {
>>    fileNameMap = map = new FileNameMap() { ... }
>> }
>> return map;
>>
>> The rest looks okay to me.
>
> I updated URLConnection accordingly
>
> http://cr.openjdk.java.net/~bpb/8146215/webrev.04/ 
> <http://cr.openjdk.java.net/%7Ebpb/8146215/webrev.04/>
>
> and reran the test job successfully. I assume that this should be good 
> to go now.
>
> Thanks,
>
> Brian



More information about the nio-dev mailing list