JDK 9 RFR of 8050499: (ch) NativeSignal.signal fails with error 316 on OS X

Alan Bateman Alan.Bateman at oracle.com
Tue Jan 5 12:34:52 UTC 2016


On 05/01/2016 02:09, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8050499
> Patch:	http://cr.openjdk.java.net/~bpb/8050499/webrev.00/
>
> Summary:
>
> On OSX ignore ESRCH returned by pthread_kill().
>
As a temporary fix then I think this probably okay but I assume the real 
issue here is that readerThread/writerThread are being set/cleared 
without stateLock. Maybe it's time to address this and also look at 
ServerSocketChannelImpl which I assume has the same issue. We can also 
look at SocketChannelImpl where this issue has been fixed but where 
readerThread/writerThread has been left as volatile and this might not 
be needed now.

For the test then it might be good to rename it something like 
StressNativeSignal or something else that makes it clearer what the test 
is for.

One other question about the test, can it run on all platforms? I assume 
@requires os.family == "mac" is not needed.

-Alan.




More information about the nio-dev mailing list