JDK 9 RFR of 8050499: (ch) NativeSignal.signal fails with error 316 on OS X

[Alan Bateman]

On 05/01/2016 18:40, Brian Burkhalter wrote:
>
> On Jan 5, 2016, at 4:34 AM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>>> On OSX ignore ESRCH returned by pthread_kill().
>>>
>> As a temporary fix then I think this probably okay but I assume the 
>> real issue here is that readerThread/writerThread are being 
>> set/cleared without stateLock. Maybe it's time to address this and 
>> also look at ServerSocketChannelImpl which I assume has the same 
>> issue. We can also look at SocketChannelImpl where this issue has 
>> been fixed but where readerThread/writerThread has been left as 
>> volatile and this might not be needed now.
>
> Yes, I saw the comments in the issue that further work might be 
> necessary in this area. Would it be appropriate to resolve this issue 
> with the current patch and file another, separate issue to follow up 
> the aforementioned root cause(s)?
Yes, that would be okay.


>
>> For the test then it might be good to rename it something like 
>> StressNativeSignal or something else that makes it clearer what the 
>> test is for.
>>
>> One other question about the test, can it run on all platforms? I 
>> assume @requires os.family == "mac" is not needed.
>
> The above changes are made in this patch:
>
> http://cr.openjdk.java.net/~bpb/8050499/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8050499/webrev.01/>
>
> I’ll run it on all platforms also.
>
Thanks, it looks good to me.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160105/40a609ae/attachment.html>