RFR: 8141595: java/nio/channels/ServerSocketChannel/NonBlockingAccept.java fails intermittently
Alan Bateman
Alan.Bateman at oracle.com
Fri Jan 15 09:02:25 UTC 2016
On 15/01/2016 05:29, Hamlin Li wrote:
> Hi everyone,
>
> Would you please help to review the fix for
> https://bugs.openjdk.java.net/browse/JDK-8141595,
> java/nio/channels/ServerSocketChannel/NonBlockingAccept.java fails
> intermittently.
> webrev : http://cr.openjdk.java.net/~mli/8141595/webrev.00/
Another old test using Thread.sleep :-)
I assume the issue is that the sleep time is not sufficient on busy
systems. Your approach is okay but would be good to keep the coding
style / line length consistent etc. An alternative is not to drop LOOPS
and let it loop until a connection is accepted or the test is timed out
by jtreg.
-Alan
More information about the nio-dev
mailing list