RFR: 8147468: Allow users to bound the size of buffers cached in the per-thread buffer caches

[Brian Burkhalter]

Tony,

Alan’s review should suffice.

While we’re at it however, I would like to point out a minor stylistic thing which is that a constant such as “maxCachedBufferSize” is by convention normally named in CAPS such as MAX_CACHED_BUFFER_SIZE and placed at the top of the class as is done here with TEMP_BUF_POOL_SZE.

Thanks,

Brian

On Jan 22, 2016, at 6:27 AM, Tony Printezis <tprintezis at twitter.com> wrote:

> Alan,
> 
> Great! What’s the next step? We need one more review?
> 
> Tony
> 
> On January 22, 2016 at 11:35:19 AM, Alan Bateman (alan.bateman at oracle.com) wrote:
> 
>> 
>> 
>> On 21/01/2016 16:34, Tony Printezis wrote:
>>> Alan,
>>> 
>>> Thanks for the comments. Please take a look at:
>>> 
>>> http://cr.openjdk.java.net/~tonyp/nio-max-buffer-size/webrev.3/
>>> 
>>> * changed jdk.nio.MaxCachedBufferSize to jdk.nio.maxCachedBufferSize
>>> * changed the copyright to the right (I hope!) version and put the right copyright dates
>>> * test now checks hasRemaining() instead of catching BufferOverflowException (I also had to change the buffer put to be done as bytes, instead of ints, given that ints are 4-byte aligned and the calculated buffer size was not)
>>> * I now create a FileChannel directly
>>> 
>>> Tony
>>> 
>> Thanks Tony, this looks good to me.
>> 
>> -Alan.
> -----
> 
> Tony Printezis | JVM/GC Engineer / VM Team | Twitter
> 
> @TonyPrintezis
> tprintezis at twitter.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160122/decfc0eb/attachment.html>