RFR: 8147468: Allow users to bound the size of buffers cached in the per-thread buffer caches

Tony Printezis tprintezis at twitter.com
Mon Jan 25 18:53:00 UTC 2016


Alan and Brian,

webrev with this fix here:

http://cr.openjdk.java.net/~tonyp/nio-max-buffer-size/webrev.4/

I also reduced the number of iterations in the test from 20,000 to 10,000 to cut down the time it takes to run the test. Hope that’s OK.

Tony

On January 23, 2016 at 10:32:52 AM, Alan Bateman (alan.bateman at oracle.com) wrote:



On 22/01/2016 16:12, Brian Burkhalter wrote:

While we’re at it however, I would like to point out a minor stylistic thing which is that a constant such as “maxCachedBufferSize” is by convention normally named in CAPS such as MAX_CACHED_BUFFER_SIZE and placed at the top of the class as is done here with TEMP_BUF_POOL_SZE.

Good point, it would be nice to make this consistent before pushing this change.

-Alan.
-----

Tony Printezis | JVM/GC Engineer / VM Team | Twitter

@TonyPrintezis
tprintezis at twitter.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160125/cd244d8d/attachment.html>


More information about the nio-dev mailing list