JDK 9 RFR of 8160018: (fs) Remove GioFileTypeDetector on Solaris
Brian Burkhalter
brian.burkhalter at oracle.com
Fri Jul 1 19:27:02 UTC 2016
An updated patch is viewable at
http://cr.openjdk.java.net/~bpb/8160018/webrev.01/
It includes a patch to remove a reference to previously excised sun/nio/fs/GnomeFileTypeDetector.java from the top level CompileJavaModules.gmk. I thought that this is sufficiently related to be included here.
A regression run with these patches applies passed.
Thanks,
Brian
On Jun 30, 2016, at 3:06 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> Hi Roger,
>
> Good point. Now that you mention it I think the GioFileTypeDetector.java should be moved from under ‘unix’ to under ‘linux’ as now it is only used on Linux. I’ll create another webrev.
>
> Thanks,
>
> Brian
>
> On Jun 30, 2016, at 2:28 PM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>
>> Hi Brian,
>>
>> Should the GioFileTypeDetector.java also be excluded from the Solaris build to save a bit of space and avoid confusion?
>>
>> The rest looks ok.
>>
>> Roger
>>
>>
>> On 6/30/2016 4:19 PM, Brian Burkhalter wrote:
>>> Please review at your convenience.
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8160018
>>> Patch: http://cr.openjdk.java.net/~bpb/8160018/
>>>
>>> The Solaris builds succeed and the core NIO regression tests pass with this change applied.
>>>
>>> Thanks,
>>>
>>> Brian
>>
>
More information about the nio-dev
mailing list