JDK 9 RFR of 8160687: (fs) Cannot tell which WatchService test is not deleting temp directories "work*"

Roger Riggs Roger.Riggs at Oracle.com
Fri Jul 1 19:45:22 UTC 2016


Looks fine for an added diagnostic.

Roger


On 7/1/2016 3:32 PM, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:https://bugs.openjdk.java.net/browse/JDK-8160687
> Diff:included below
>
> Regression test run succeeded.
>
> Thanks,
>
> Brian
>
> --- a/test/java/nio/file/WatchService/DeleteInterference.java
> +++ b/test/java/nio/file/WatchService/DeleteInterference.java
> @@ -49,7 +49,7 @@
>       * directory.
>       */
>      public static void main(String[] args) throws Exception {
> -        Path dir = Files.createTempDirectory("work");
> +        Path dir = Files.createTempDirectory(“DeleteInterference");
> ExecutorService pool = Executors.newCachedThreadPool();
>          try {
> Future<?> task1 = pool.submit(() -> openAndCloseWatcher(dir));
>
> --- a/test/java/nio/file/WatchService/LotsOfCancels.java
> +++ b/test/java/nio/file/WatchService/LotsOfCancels.java
> @@ -50,7 +50,7 @@
>          // one to bash on cancel, the other to poll the events
> ExecutorService pool = Executors.newCachedThreadPool();
>          try {
> - Path top = Files.createTempDirectory("work");
> + Path top = Files.createTempDirectory(“LotsOfCancels");
> top.toFile().deleteOnExit();
>              for (int i=1; i<=16; i++) {
> Path dir = Files.createDirectory(top.resolve("dir-" + i));



More information about the nio-dev mailing list