JDK 9 RFR of 8160220: (fs) Tests in jdk/test/java/nio/file/WatchService leave directory trees behind

Alan Bateman Alan.Bateman at oracle.com
Tue Jul 12 06:28:29 UTC 2016


On 12/07/2016 01:21, Brian Burkhalter wrote:

> Please review at your convenience.
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8160220
> Patch:	http://cr.openjdk.java.net/~bpb/8160220/webrev.00/
>
> Summary:
>
> 1) DeleteInterference & LotsOfCancels
>
> Create temporary files in a directory specifiable via the “test.dir” property with default “.”.
This looks okay although I assume you don't need createTempDirectory, it 
can be just a fixed sub-directory of the current directory (up to you).
>
> 2) LotsOfCancels
>
> Add (probably redundant) deletion of temporary file tree.
>
The tests in this area use TestUtil.removeAll so you don't need to add 
deleteFileTree. Also if you expand the scope of the try/finally then you 
can get rid of deleteOnExit.

-Alan


More information about the nio-dev mailing list